pidgin: dc564039: Remove a bunch of *_init() and *_uninit(...

datallah at pidgin.im datallah at pidgin.im
Wed Aug 6 23:16:04 EDT 2008


-----------------------------------------------------------------
Revision: dc56403926c4d47f16a146b6fd482488bf0c4398
Ancestor: 234c6f6e80a62bab664601e395de22d15e5303d0
Author: datallah at pidgin.im
Date: 2008-08-07T03:10:44
Branch: im.pidgin.pidgin
URL: http://d.pidgin.im/viewmtn/revision/info/dc56403926c4d47f16a146b6fd482488bf0c4398

Modified files:
        libpurple/plugins/perl/common/Account.xs
        libpurple/plugins/perl/common/BuddyIcon.xs
        libpurple/plugins/perl/common/BuddyList.xs
        libpurple/plugins/perl/common/Cipher.xs
        libpurple/plugins/perl/common/Connection.xs
        libpurple/plugins/perl/common/Conversation.xs
        libpurple/plugins/perl/common/Log.xs
        libpurple/plugins/perl/common/Network.xs
        libpurple/plugins/perl/common/Plugin.xs
        libpurple/plugins/perl/common/Pounce.xs
        libpurple/plugins/perl/common/Prefs.xs
        libpurple/plugins/perl/common/Privacy.xs
        libpurple/plugins/perl/common/Proxy.xs
        libpurple/plugins/perl/common/SSLConn.xs
        libpurple/plugins/perl/common/SavedStatuses.xs
        libpurple/plugins/perl/common/Sound.xs
        libpurple/plugins/perl/common/Status.xs
        libpurple/plugins/perl/common/Util.xs

ChangeLog: 

Remove a bunch of *_init() and *_uninit() functions that don't make sense for
Perl plugins to call.
Plug a couple leaks.
Mark a couple functions that need to be fixed.

-------------- next part --------------
============================================================
--- libpurple/plugins/perl/common/Account.xs	a83ea814db86d377b4817cc538bcd888084fa999
+++ libpurple/plugins/perl/common/Account.xs	7081b9b41d621571c4fc2a7f3dc1a969abf66e04
@@ -319,9 +319,3 @@ purple_accounts_get_handle()
 
 Purple::Handle
 purple_accounts_get_handle()
-
-void
-purple_accounts_init()
-
-void
-purple_accounts_uninit()
============================================================
--- libpurple/plugins/perl/common/BuddyIcon.xs	d02567b82a69afc8e8d46bfe2177ede722431a54
+++ libpurple/plugins/perl/common/BuddyIcon.xs	749e713467c96ef046ad9b7ff55b24f5c5b1cdd1
@@ -45,7 +45,7 @@ purple_buddy_icon_get_scale_size(spec, w
 	int *width
 	int *height
 
-char *
+gchar_own *
 purple_buddy_icon_get_full_path(icon);
 	Purple::Buddy::Icon icon
 
@@ -69,8 +69,3 @@ purple_buddy_icons_get_handle();
 Purple::Handle
 purple_buddy_icons_get_handle();
 
-void
-purple_buddy_icons_init();
-
-void
-purple_buddy_icons_uninit()
============================================================
--- libpurple/plugins/perl/common/BuddyList.xs	57e669b305b0533a7d43b7d7dd9a5ddbeb22bb8f
+++ libpurple/plugins/perl/common/BuddyList.xs	368d1c7e753555589174487c8a6c7a8fee6f6c3f
@@ -259,12 +259,6 @@ purple_blist_get_root()
 Purple::BuddyList::Node
 purple_blist_get_root()
 
-void
-purple_blist_init()
-
-void
-purple_blist_uninit()
-
 MODULE = Purple::BuddyList  PACKAGE = Purple::BuddyList::Node  PREFIX = purple_blist_node_
 PROTOTYPES: ENABLE
 
============================================================
--- libpurple/plugins/perl/common/Cipher.xs	bca241c870a5ff18970915b782563b1a9585cb47
+++ libpurple/plugins/perl/common/Cipher.xs	1826b41daee220db29be79ed137ee1355936916a
@@ -128,12 +128,6 @@ purple_ciphers_get_handle()
 Purple::Handle
 purple_ciphers_get_handle()
 
-void
-purple_ciphers_init()
-
-void
-purple_ciphers_uninit()
-
 MODULE = Purple::Cipher  PACKAGE = Purple::Cipher::Context  PREFIX = purple_cipher_context_
 PROTOTYPES: ENABLE
 
============================================================
--- libpurple/plugins/perl/common/Connection.xs	932a3b80a28c38ed6d79b27a4fd97fb7c7ef3303
+++ libpurple/plugins/perl/common/Connection.xs	5613331867768db0e472566cdba98369ed71ef5c
@@ -94,11 +94,5 @@ purple_connections_get_ui_ops()
 Purple::Connection::UiOps
 purple_connections_get_ui_ops()
 
-void
-purple_connections_init()
-
-void
-purple_connections_uninit()
-
 Purple::Handle
 purple_connections_get_handle()
============================================================
--- libpurple/plugins/perl/common/Conversation.xs	73ea4dc9a526d9fc224b5d0e985ee5958a2a9260
+++ libpurple/plugins/perl/common/Conversation.xs	e53bdbc2ad517b46d9942020555ea4ed4956e2c2
@@ -124,12 +124,6 @@ purple_conversations_get_handle()
 Purple::Handle
 purple_conversations_get_handle()
 
-void
-purple_conversations_init()
-
-void
-purple_conversations_uninit()
-
 MODULE = Purple::Conversation  PACKAGE = Purple::Conversation  PREFIX = purple_conversation_
 PROTOTYPES: ENABLE
 
============================================================
--- libpurple/plugins/perl/common/Log.xs	aaa49ba972b17f30bf8c9137b81afc0c8aaf53f6
+++ libpurple/plugins/perl/common/Log.xs	e8a472a89b20ecc1855dfe9d469991d5c47f7bcf
@@ -100,9 +100,6 @@ void
 	Purple::Account account
 
 void
-purple_log_init()
-
-void
 purple_log_logger_free(logger)
 	Purple::Log::Logger logger
 
============================================================
--- libpurple/plugins/perl/common/Network.xs	40e8901d45ec5487107d9618026b88f9cfdc3cba
+++ libpurple/plugins/perl/common/Network.xs	33be31409873a5822c7a3363b87b9ad1d621170c
@@ -18,9 +18,6 @@ purple_network_get_public_ip()
 const char *
 purple_network_get_public_ip()
 
-void
-purple_network_init()
-
 const unsigned char *
 purple_network_ip_atoi(ip)
 	const char *ip
============================================================
--- libpurple/plugins/perl/common/Plugin.xs	e613b27b91d766d32b587b134d4da97fa6cce315
+++ libpurple/plugins/perl/common/Plugin.xs	730c4419105f3d42467696321430f4a5fdad8e9c
@@ -164,9 +164,3 @@ purple_plugins_get_handle()
 
 Purple::Handle
 purple_plugins_get_handle()
-
-void
-purple_plugins_init()
-
-void
-purple_plugins_uninit()
============================================================
--- libpurple/plugins/perl/common/Pounce.xs	be86cf661f81767fa956a726c1a90b9b84ba5261
+++ libpurple/plugins/perl/common/Pounce.xs	49c0a1ce1e0ed94128bacfe1f1b5167677fee634
@@ -121,15 +121,9 @@ purple_pounces_get_handle()
 Purple::Handle
 purple_pounces_get_handle()
 
-void
-purple_pounces_init()
-
 gboolean
 purple_pounces_load()
 
 void
-purple_pounces_uninit()
-
-void
 purple_pounces_unregister_handler(ui)
 	const char *ui
============================================================
--- libpurple/plugins/perl/common/Prefs.xs	f2e7e8372d62638b75bc3f72f2ff25481b5f92ec
+++ libpurple/plugins/perl/common/Prefs.xs	b57ed2e73348096b519744460e2e6a2ab8066a7e
@@ -119,9 +119,6 @@ purple_prefs_get_type(name)
 purple_prefs_get_type(name)
 	const char *name
 
-void
-purple_prefs_init()
-
 gboolean
 purple_prefs_load()
 
@@ -192,7 +189,4 @@ void
 	}
 
 void
-purple_prefs_uninit()
-
-void
 purple_prefs_update_old()
============================================================
--- libpurple/plugins/perl/common/Privacy.xs	062709490d163134c282f027b209d0be9fef6148
+++ libpurple/plugins/perl/common/Privacy.xs	b82e1fb4c6671b69f61222c2a29a16b592f38b0b
@@ -7,9 +7,6 @@ void
 purple_privacy_get_ui_ops()
 
 void
-purple_privacy_init()
-
-void
 purple_privacy_set_ui_ops(ops)
 	Purple::Privacy::UiOps ops
 
============================================================
--- libpurple/plugins/perl/common/Proxy.xs	04dd11d14f180b76f68240e718216ecae966b4e1
+++ libpurple/plugins/perl/common/Proxy.xs	cad36d5bfd82eae380e05c7d31363c9bb05a5a83
@@ -24,9 +24,6 @@ purple_proxy_get_handle()
 Purple::Handle
 purple_proxy_get_handle()
 
-void
-purple_proxy_init()
-
 MODULE = Purple::Proxy  PACKAGE = Purple::ProxyInfo  PREFIX = purple_proxy_info_
 PROTOTYPES: ENABLE
 
============================================================
--- libpurple/plugins/perl/common/SSLConn.xs	f180fc10aa6ba3af5ec5740bd63896ae60e56fc2
+++ libpurple/plugins/perl/common/SSLConn.xs	d9a4f2bccbf141bd8cc3c0e7734707ec5e886d90
@@ -35,9 +35,6 @@ purple_ssl_get_ops()
 Purple::Ssl::Ops
 purple_ssl_get_ops()
 
-void
-purple_ssl_init()
-
 gboolean
 purple_ssl_is_supported()
 
@@ -51,9 +48,6 @@ purple_ssl_set_ops(ops)
 purple_ssl_set_ops(ops)
 	Purple::Ssl::Ops ops
 
-void
-purple_ssl_uninit()
-
 size_t
 purple_ssl_write(gsc, buffer, len)
 	Purple::Ssl::Connection gsc
============================================================
--- libpurple/plugins/perl/common/SavedStatuses.xs	baf69bfabf99913a2f891267acf96af435bdf413
+++ libpurple/plugins/perl/common/SavedStatuses.xs	9c45c538cd3797b308ac01b214bd98286c2c0bc4
@@ -150,9 +150,3 @@ purple_savedstatuses_get_handle()
 
 Purple::Handle
 purple_savedstatuses_get_handle()
-
-void
-purple_savedstatuses_init()
-
-void
-purple_savedstatuses_uninit()
============================================================
--- libpurple/plugins/perl/common/Sound.xs	2126f59386b825d39ab70e8ac38d892a643abc61
+++ libpurple/plugins/perl/common/Sound.xs	2d49655891e61280c4d8daac3cf96d32c342de8f
@@ -30,9 +30,6 @@ void
 purple_sound_get_ui_ops()
 
 void
-purple_sound_init()
-
-void
 purple_sound_play_event(event, account)
 	Purple::SoundEventID event
 	Purple::Account account
@@ -45,6 +42,3 @@ purple_sound_set_ui_ops(ops)
 void
 purple_sound_set_ui_ops(ops)
 	Purple::Sound::UiOps ops
-
-void
-purple_sound_uninit()
============================================================
--- libpurple/plugins/perl/common/Status.xs	f9abdbbf08dd2535baedad32221a26c2f31301e3
+++ libpurple/plugins/perl/common/Status.xs	ffbac7144d6270ec093cbc909842ee28e4476ed2
@@ -341,12 +341,6 @@ purple_status_set_attr_string(status, id
 	const char *id
 	const char *value
 
-void
-purple_status_init()
-
-void
-purple_status_uninit()
-
 MODULE = Purple::Status  PACKAGE = Purple::StatusType  PREFIX = purple_status_type_
 PROTOTYPES: ENABLE
 
============================================================
--- libpurple/plugins/perl/common/Util.xs	94c2a17e2cdf9fc26f203fecb1907d9b900c1998
+++ libpurple/plugins/perl/common/Util.xs	aae0d34b5d7e14aa36eff97035608355cafb0adb
@@ -202,7 +202,7 @@ purple_utf8_ncr_encode(in)
 purple_utf8_ncr_encode(in)
 	const char* in
 
-gchar*
+gchar_own*
 purple_utf8_salvage(str)
 	const char* str
 
@@ -356,6 +356,7 @@ purple_str_size_to_units(size)
 purple_str_size_to_units(size)
 	size_t size
 
+#TODO: Fix this to handle str being modified in-place
 void
 purple_str_strip_char(str, thechar)
 	char *str
@@ -513,6 +514,7 @@ purple_util_set_current_song(title, arti
 	const char *artist
 	const char *album
 
+#TODO: Fix this to handle str being modified in-place
 void
 purple_util_chrreplace(string, delimiter, replacement)
 	char* string


More information about the Commits mailing list