im.pidgin.pidgin: 3cec6952fcadbd73dddc4c009e798b6fb1789a5b

[Evan Schoenberg]

On Dec 21, 2007, at 3:44 PM, Daniel Atallah wrote:

> Added support for authentication via CRAM-MD5 when using jabber:iq:auth 
> .
> This, combined with 33785a8c844de496aeeed927bad8b39a6e091931, fixes  
> connectivity with iChat Server 10.5 (a jabberd derivative with SASL  
> support), among other servers, when libpurple is compiled with SASL  
> support.
>
>
> This looks not quite right to me - the fifth argument to  
> auth_hmac_md5() is a guchar*, but it is being passed a guchar**.

I agree - that's not right.  I find it very strange that it both works  
as I committed it originally (wrong type) and as I've just committed  
in 16e6cd4ffd8a8308380dc016f0afa782a7750374 (Just pass 'digest', not a  
pointer to digest)... Magic? Thanks for the catch... and if there's  
learning to be had as to why both versions worked, I'd love to hear  
it :)

-Evan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://pidgin.im/pipermail/devel/attachments/20071222/15a6c491/attachment-0001.html>