[Pidgin] #7323: Pidgin does not reconnect after Networkmanager sent StateChange
Pidgin
trac at pidgin.im
Wed Oct 22 17:15:51 EDT 2008
#7323: Pidgin does not reconnect after Networkmanager sent StateChange
--------------------------------------+-------------------------------------
Reporter: aneiser | Owner:
Type: patch | Status: new
Milestone: | Component: libpurple
Version: 2.5.2 | Resolution:
Keywords: networkmanager reconnect |
--------------------------------------+-------------------------------------
Comment(by aneiser):
Well, obviously the 'nm_dbus_name_owner_changed_cb()' is not fired at
startup (otherwise I would see some messages with `pidgin --debug | grep
network`). Does that make sense? I mean what is changed at the start of
pidgin regarding dbus? In my opinion nothing, so no callbacks should be
fired (and this is the case at the moment).
The main problem is that in the beginning the routine 'nm_update_state()'
does not know about the correct status when Pidgin starts. So, why should
it harm after setting up the connection to NM over Dbus to ask for current
status and tell it 'nm_update_state()'? Even if NM is not present we get a
NM_STATUS_UNKNOWN and nothing evil happens.
But your proposal seems reasonable, too. I mean why do we care about the
previous unknown state when we know that we're disconnected know. I'll if
I can make a patch for your proposal tomorrow and test it a bit.
--
Ticket URL: <http://developer.pidgin.im/ticket/7323#comment:5>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list