[Pidgin] #7516: XMPP "headline" messages create new conversation tab in 2.5.2

[Pidgin]

#7516: XMPP "headline" messages create new conversation tab in 2.5.2
-------------------+--------------------------------------------------------
 Reporter:  jts    |        Owner:  deryni
     Type:  patch  |       Status:  new   
Milestone:         |    Component:  XMPP  
  Version:  2.5.2  |   Resolution:        
 Keywords:         |  
-------------------+--------------------------------------------------------

Comment(by darkrain42):

 Replying to [comment:7 jts]:
 > @darkrain42: I'm not sure I follow. The code in question
 (creating/finding the conv tab) shouldn't execute for a headline message
 regardless of the smileys, correct? I was trying to make a minimal-change
 patch, ie, only opt-out the conv tab for headlines rather than enumerate
 the opt-in cases.

 Minimal is good (at least, IMHO), but the advantage of opt-in is that the
 code really should only be creating a conversation and parsing for custom
 smileys in the cases where the message will be displayed with the smileys,
 which is why I believe it is correct to enumerate the allowed cases
 (alternatively, one could explicitly disallow the incorrect cases of
 error, headline, etc...)

-- 
Ticket URL: <http://developer.pidgin.im/ticket/7516#comment:8>
Pidgin <http://pidgin.im>
Pidgin