[Pidgin] #13298: Cannot add msn buddy: error msg about invalid email address

[Pidgin]

#13298: Cannot add msn buddy: error msg about invalid email address
---------------------+------------------------------------------------------
 Reporter:  flohack  |        Owner:  QuLogic
     Type:  defect   |       Status:  new    
Milestone:           |    Component:  MSN    
  Version:  2.7.9    |   Resolution:         
 Keywords:           |  
---------------------+------------------------------------------------------

Comment(by MarkDoliner):

 I've spent a little time looking at this and plan to look at it a little
 more tonight.  For starters the msn_email_is_valid() function is fine and
 working correctly.  The error message comes from line 1777 of msn.c (not
 line 1872).  At this point we've already used msn_email_is_valid() to
 check that the name is indeed valid.  We print the error on line 1777
 because the server gives us MSN_NETWORK_UNKNOWN as the type.  I'm not sure
 why the server is doing that.

 One thing that's interesting is that I can reproduce this in Pidgin if I
 remove a buddy then re-add them without signing out in between.  If I
 remove a buddy, sign out, sign back in, add the buddy, it works fine
 (maybe not 100% of the time... my sample size is too small to know).

 Here's what a successful add looks like from the official Windows Live
 Messenger client on WinXP:
 {{{
 Packet capture from Windows Live Messenger successfully adding a contact.
 SEND:  ADL 17 64\r\n<ml><d n="hotmail.com"><c n="markdoliner" l="2"
 t="1"/></d></ml>
 RECV:  ADL 17 OK
 SEND:  ADL 18 64\r\n<ml><d n="hotmail.com"><c n="markdoliner" l="1"
 t="1"/></d></ml>
 RECV:  ADL 18 OK
 SEND:  FQY 19 52\r\n<ml><d n="hotmail.com"><c n="markdoliner"/></d></ml>

 RECV:  NLN AWY 1:markdoliner at hotmail.com Mark 12345:67890 MORE_STUFF_HERE
 RECV:  UBX 1:markdoliner at hotmail.com 590 MORE_STUFF_HERE
 }}}

 When I'm able to successfully add the buddy from Pidgin the network
 traffic looks identical to the above (with the exception of the
 transaction ID).

 When I get the error message in question the network traffic looks like
 this:
 {{{
 SEND:  FQY 23 52\r\n<ml><d n="hotmail.com"><c n="markdoliner"/></d></ml>
 RECV:  FQY 23 59\r\n<ml><d n="hotmail.com"><c n="markdoliner" t="0"
 /></d></ml>
 }}}

 I don't know why we send the FQY on this occasion, nor why it fails or
 what it's supposed to look like.

-- 
Ticket URL: <http://developer.pidgin.im/ticket/13298#comment:37>
Pidgin <http://pidgin.im>
Pidgin