[Pidgin] #15666: Fix glitches in sorting by status
Pidgin
trac at pidgin.im
Wed Jun 12 19:07:18 EDT 2013
#15666: Fix glitches in sorting by status
---------------------+-----------------------
Reporter: immerrr | Owner:
Type: patch | Status: new
Milestone: | Component: libpurple
Version: 2.10.7 | Keywords:
---------------------+-----------------------
This patch should fix another ticket of mine (#15438). The problem was as
follows. I didn't dig deep into "hg blame", but apparently it's this
commit:
{{{
changeset: 24907:13118548c74c
branch: cpw.rekkanoryo.icqxstatus
user: Richard Laager <rlaager at pidgin.im>
date: Mon Nov 17 00:43:59 2008 +0000
summary: Add a PURPLE_STATUS_MOOD primitive and change ICQ to use it.
}}}
It introduced new status primitive, but didn't update `SCORE_IDLE`,
`SCORE_IDLE_TIME` and `SCORE_OFFLINE_MESSAGE` constants which resulted in
score status shift: corresponding scores changed from -10, -5, 10 to 0,
-10, -5.
Not only that, my prefs.xml file was generated before the advent of ICQ
moods, so it had old an old value cached for SCORE_IDLE, causing even more
havoc as it effectively updated PURPLE_STATUS_MOOD's score upon reading
the config.
I'm attaching the patch that fixes the issue for me.
--
Ticket URL: <https://developer.pidgin.im/ticket/15666>
Pidgin <http://pidgin.im>
Pidgin
More information about the Tracker
mailing list